Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Fix LXD VM metadata test (SC-990) #1430

Merged
merged 1 commit into from
May 5, 2022
Merged

testing: Fix LXD VM metadata test (SC-990) #1430

merged 1 commit into from
May 5, 2022

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

testing: Fix LXD VM metadata test

Jammy additions changed the non-jammy subplatform check in a way that
caused failure.

@TheRealFalcon
testing: Fix LXD VM metadata test
e8ea455 
Jammy additions changed the non-jammy subplatform check in a way that
caused failure
@TheRealFalcon TheRealFalcon changed the title testing: Fix LXD VM metadata test testing: Fix LXD VM metadata test (SC-990) May 5, 2022
blackboxsw
blackboxsw approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed will fix failures cases such as
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-bionic-lxd_vm/16/testReport/tests.integration_tests.modules.test_combined/TestCombined/test_instance_json_lxd_vm/

@blackboxsw blackboxsw merged commit faaa055 into canonical:main May 5, 2022
aciba90 pushed a commit to aciba90/cloud-init that referenced this pull request May 10, 2022
@TheRealFalcon @aciba90
testing: Fix LXD VM metadata test (canonical#1430)
a73c5df 
Jammy additions changed the non-jammy subplatform check in a way that
caused failure
This was referenced May 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackboxsw blackboxsw blackboxsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealFalcon @blackboxsw