sources/azure: remove reprovisioning marker #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: Prior to merging, needs review/approval from @anhvoms :) |
If we haven't reported ready for source PPS then we can treat the recovery boot like any other. The metadata on the OVF and IMDS will indicate the PPS type correctly as the state hasn't changed. If we have reported ready for source PPS, we continue to fall into _poll_imds() by way of setting pps_type to UNKNOWN if the REPORTED_READY_MARKER is present and will not attempt to report ready again. This fixes a potential issue when recovering on Savable PPS. If a recovery boot occurs after the recovery marker is created, and without reporting ready, the subsequent boot will assume pps type UNKNOWN and attempt to report ready in _poll_imds() using the Running PPS netlink operations. Add unit test coverage for complete recovery scenario. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-remove-reprovisioning-marker
branch
from
75984f6 to
706dcd0
Compare
aciba90
pushed a commit
to aciba90/cloud-init
that referenced
this pull request
May 10, 2022
If we haven't reported ready for source PPS then we can treat the recovery boot like any other. The metadata on the OVF and IMDS will indicate the PPS type correctly as the state hasn't changed. If we have reported ready for source PPS, we continue to fall into _poll_imds() by way of setting pps_type to UNKNOWN if the REPORTED_READY_MARKER is present and will not attempt to report ready again. This fixes a potential issue when recovering on Savable PPS. If a recovery boot occurs after the recovery marker is created, and without reporting ready, the subsequent boot will assume pps type UNKNOWN and attempt to report ready in _poll_imds() using the Running PPS netlink operations. Add unit test coverage for complete recovery scenario. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we haven't reported ready for source PPS then we can treat
the recovery boot like any other. The metadata on the OVF
and IMDS will indicate the PPS type correctly as the state
hasn't changed.
If we have reported ready for source PPS, we continue to fall
into _poll_imds() by way of setting pps_type to UNKNOWN if the
REPORTED_READY_MARKER is present and will not attempt to report
ready again.
This fixes a potential issue when recovering on Savable PPS.
If a recovery boot occurs after the recovery marker is created,
and without reporting ready, the subsequent boot will assume
pps type UNKNOWN and attempt to report ready in _poll_imds()
using the Running PPS netlink operations.
Add unit test coverage for complete recovery scenario.
Signed-off-by: Chris Patterson cpatterson@microsoft.com