Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: disable missing imports warning for httpretty #1412

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

cjp256
Copy link
Contributor

@cjp256 cjp256 commented Apr 27, 2022

httpretty does not appear to support mypy stubs. Add configuration
to for mypy to ignore this import.

With this we can add checking for test_azure.py.

Signed-off-by: Chris Patterson cpatterson@microsoft.com

httpretty does not appear to support mypy stubs. Add configuration
to for mypy to ignore this import.

With this we can add checking for test_azure.py.

Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming CI passes. We're hoping to replace httpretty with responses in the near future due to all the httpretty issues we've had.

@TheRealFalcon TheRealFalcon merged commit 2f496d6 into canonical:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants