Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy stubs and other tox maintenance (SC-920) #1374

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Mypy stubs and other tox maintenance (SC-920) #1374

merged 3 commits into from
Apr 12, 2022

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Apr 10, 2022 •
edited
Loading 

Mypy stubs and other tox maintenance

 - add type stubs for mypy: jinja, jsonschema, oauthlib
 - specify mypy directories to avoid env/ false positive
 - add conftest.py and setup.py
 - make setup.py pass pylint:
   - check ./tools/render-cloudcfg return code in setup.py
   - find_sources() has no return code, don't check for one

find_sources has never had a return code: pypa/setuptools@873ebe9

holmanb added 2 commits April 10, 2022 00:12
@holmanb
Mypy stubs and other tox maintenance
59a9a23 
 - add type stubs for mypy: jinja, jsonschema, oauthlib
 - specify mypy directories to avoid env/ false positive
 - add conftest.py and setup.py
@holmanb
Apply pylint suggestions to setup.py
2bb599b 
- don't ignore subproc return code (check=True)
- setuptools.command.egginfo.find_sources() has never had a return code,
  don't pass one
@holmanb holmanb force-pushed the holmanb/tox-maint branch from 91eb62a to 2bb599b Compare April 10, 2022 20:24
@holmanb holmanb changed the title Mypy stubs and other tox maintenance Mypy stubs and other tox maintenance (SC-920) Apr 10, 2022
TheRealFalcon
TheRealFalcon requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove all the types-Jinja2 references, but otherwise looks good!

tox.ini Outdated Show resolved Hide resolved
@holmanb
Copy link
Member Author

holmanb commented Apr 12, 2022

I think we need to remove all the types-Jinja2 references, but otherwise looks good!

@TheRealFalcon Thanks for the review! Fixed.

TheRealFalcon
TheRealFalcon approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tox.ini Outdated Show resolved Hide resolved
@TheRealFalcon TheRealFalcon merged commit 1b2d069 into canonical:main Apr 12, 2022
This was referenced May 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holmanb @TheRealFalcon