-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add JSON schema for mcollective, migrator and mounts modules #1358
Conversation
d95b523
to
2aa230f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline, but overall looking good.
}, | ||
"size": { | ||
"description": "The size in bytes of the swap file, or 'auto'", | ||
"oneOf": [{"enum": ["auto"]}, {"type": "integer"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoa nice find will add a positive example here in meta schema and fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added "pattern": "^([0-9]+)?\\.?[0-9]+[BKMGT]$"}
to schema for swap.size swap.maxsize and unittests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo we should fix, and everything else optional. For some reason Github wouldn't let me do suggestions on this review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Proposed Commit Message
Additional Context
Test Steps
Unit tests will run through any included cc_.meta['examples'] to confirm that they are correct schema.
Checklist: