Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor_data2 support for ConfigDrive source #1307

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

cvstealth
Copy link
Contributor

Proposed Commit Message

Summary: Support vendor_data2 as a source of data when using a ConfigDrive

When using a ConfigDrive as a data source for cloud-init only vendordata is currently evaluated.  This patch adds support for vendor_data2 when used with ConfigDrive and aligns with the same feature parity that is found when using the OpenStack Neutron metadata service (DataSourceOpenStack.py).

Test Steps

Generate a OpenStack configuration drive that contains vendor_data2.json and verify the context of the JSON file are properly executed.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to cloud-init!

This PR looks good to me. CI never returned from Travis, so I'm going to close and re-open this PR to re-trigger CI. If that passes then we should be good to merge.

@TheRealFalcon TheRealFalcon reopened this Mar 9, 2022
@TheRealFalcon TheRealFalcon merged commit 558f037 into canonical:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants