sources/azure: prevent tight loops for DHCP retries #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjp256
force-pushed
the
azure-dhcp-retry
branch
3 times, most recently
from
c4fafc0 to
8f3460b
Compare
anhvoms
reviewed
Feb 22, 2022
cjp256
force-pushed
the
azure-dhcp-retry
branch
from
8f3460b to
09e3b6d
Compare
anhvoms
approved these changes
Feb 22, 2022
cjp256
force-pushed
the
azure-dhcp-retry
branch
from
09e3b6d to
19d24ca
Compare
cjp256
force-pushed
the
azure-dhcp-retry
branch
3 times, most recently
from
b658333 to
4b12f46
Compare
|
Also updated the loop so we don't sleep if we're past the timeout. |
With debug logging, tight loops may result in huge log file sizes, e.g.: "Unable to find fallback nic" 1. Raise NoDHCPLeaseMissingDhclientError to caller if no dhclient found instead of retrying DHCP, retrying will not fix a missing dhclient. 2. For other DHCP failures, retry after sleeping one second. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
anhvoms
approved these changes
Mar 1, 2022
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With debug logging, tight loops may result in huge log file sizes, e.g.:
"Unable to find fallback nic"
Raise NoDHCPLeaseMissingDhclientError to caller if no dhclient found
instead of retrying DHCP, retrying will not fix a missing dhclient.
For other DHCP failures, retry after sleeping one second.
Signed-off-by: Chris Patterson cpatterson@microsoft.com
Depends on #1276
Would be a good candidate for SRU, if possible.