sources/azure: validate IMDS network configuration metadata #1257
Conversation
cjp256
force-pushed
the
azure-log-missing-metadata
branch
3 times, most recently
from
378e256 to
c34f236
Compare
| @@ -178,6 +178,26 @@ def find_dev_from_busdev(camcontrol_out, busdev): | |||
| return None | |||
|
|
|||
|
|
|||
| def normalize_mac_address(mac: str): | |||
| """Normalize mac address with colons and lower-case.""" | |||
There was a problem hiding this comment.
What "non-colon" formats is this expected to normalize? Just curious since I don't see any new tests in this PR that appear to make use of this. This would obviously fail the format 'HHHH.HHHH.HHHH' that some network gear vendors use, but I assume that's out of scope for the inputs that this is supposed to normalize.
There was a problem hiding this comment.
I haven't added tests yet, this was just a draft for early review :D
I expect get_interfaces() will always be in this lower-case, colon format - but I figured I'd pass it through regardless.
IMDS metadata uses upper-case w/o colons, so it needs the normalization for comparison.
There was a problem hiding this comment.
We can use this method here too:
cloud-init/cloudinit/sources/DataSourceAzure.py
Line 2274 in c34f236
cjp256
force-pushed
the
azure-log-missing-metadata
branch
3 times, most recently
from
bd6a3d8 to
0ebae8c
Compare
cjp256
force-pushed
the
azure-log-missing-metadata
branch
from
0ebae8c to
984d5b4
Compare
cjp256
force-pushed
the
azure-log-missing-metadata
branch
3 times, most recently
from
443cb30 to
eee1ee9
Compare
Due to race conditions and caching, IMDS may return stale or incomplete metadata. Add some validation to detect these scenarios and report appropriate telemetry. Introduce normalize_mac_address() to allow for comparison of mac addresses, replacing that found inline in: _generate_network_config_from_imds_metadata() Add validation of final fetch of IMDS metadata. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-log-missing-metadata
branch
from
eee1ee9 to
f893801
Compare
Due to race conditions and caching, IMDS may return stale or incomplete
metadata. Add some validation to detect these scenarios and report
appropriate telemetry.
Signed-off-by: Chris Patterson cpatterson@microsoft.com