sources/azure: always initialize _ephemeral_dhcp_ctx on unpickle #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid requirement of getattr() and ensure _ephemeral_dhcp_ctx isn't persisted in the cache. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
anhvoms
approved these changes
Jan 19, 2022
| ) and getattr(self, "_ephemeral_dhcp_ctx", None) | ||
| use_cached_ephemeral = ( | ||
| self.distro.networking.is_up(self.fallback_interface) | ||
| and self._ephemeral_dhcp_ctx |
There was a problem hiding this comment.
Do we need to check for self._ephemeral_dhcp_ctx.lease here?
There was a problem hiding this comment.
In practice I expect that a NoDHCPLeaseError exception would have been raised and prevented it from getting this far.
I added an explicit check and I have other PRs in queue to further improve this handling.
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
anhvoms
approved these changes
Jan 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid requirement of getattr() and ensure _ephemeral_dhcp_ctx isn't
persisted in the cache.
Signed-off-by: Chris Patterson cpatterson@microsoft.com