Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Make MACs lowercase in network config (SC-541) #1135

Merged
merged 1 commit into from
Dec 6, 2021
Merged

docs: Make MACs lowercase in network config (SC-541) #1135

merged 1 commit into from
Dec 6, 2021

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

docs: Make MACs lowercase in network config

LP: #1876941

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon TheRealFalcon changed the title docs: Make MACs lowercase in network config docs: Make MACs lowercase in network config (SC-541) Dec 6, 2021
holmanb
holmanb approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grepped a bit for other spots we might need to update ((:.*){6}) and I didn't find anything. There are a few tests that have uppercase mac addresses, but those look to be mocking output from system commands, so no need to change those. LGTM

@blackboxsw blackboxsw merged commit cd40789 into canonical:main Dec 6, 2021
@TheRealFalcon TheRealFalcon deleted the mac-docs branch December 14, 2021 15:06
@ubuntu-server-builder ubuntu-server-builder mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackboxsw blackboxsw blackboxsw approved these changes

@holmanb holmanb holmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealFalcon @blackboxsw @holmanb