Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when no activator found (SC-540) #1129

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

Fix exception when no activator found

Given that there are additional network management tools that we haven't
yet supported with activators, we should log a warning and continue
without network activation here, especially since this was a no-op for
years.

LP: #1948681

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Given that there are additional network management tools that we haven't
yet supported with activators, we should log a warning and continue
without network activation here, especially since this was a no-op for
years.

LP: #1948681
@TheRealFalcon TheRealFalcon changed the title Fix exception when no activator found Fix exception when no activator found (SC-540) Dec 2, 2021
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to log a warning here. Let other distros/network stacks add support as needed.

@blackboxsw blackboxsw merged commit ffa6fc8 into canonical:main Dec 3, 2021
@TheRealFalcon TheRealFalcon deleted the activator-exception branch December 3, 2021 04:52
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants