Skip to content

Commit

Permalink
print error if datasource import fails (#1170)
Browse files Browse the repository at this point in the history
Sometimes an import might fail for different reasons: the string
is wrongly typed, or the module has a dependency that is not
installed in python.

We should print that there is an import error, otherwise it might be
really difficult to understand what is the root cause of this
issue. Currently, cloud-init just ignores the error and continues.
This can have fatal consequences when used to pick
the datasource to use.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
  • Loading branch information
esposem authored Jan 12, 2022
1 parent 5147e8d commit fe745d4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions cloudinit/sources/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,12 @@ def list_sources(cfg_list, depends, pkg_list):
m_locs, _looked_locs = importer.find_module(
ds_name, pkg_list, ["get_datasource_list"]
)
if not m_locs:
LOG.error(
"Could not import %s. Does the DataSource exist and "
"is it importable?",
ds_name,
)
for m_loc in m_locs:
mod = importer.import_module(m_loc)
lister = getattr(mod, "get_datasource_list")
Expand Down

0 comments on commit fe745d4

Please sign in to comment.