Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float castable values instead of just floats (bugfix) #1658

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Dec 17, 2024

Description

The new behaviour may introduce units that produce iologs in 0 time. This causes the validation after resume to crash and burn because 0 is not a float, but an integer. This fixes the issue by allowing any value that is float castable (which is slightly more than just integers, but I see no point in being strict about the timestamp of the iolog production!)

Resolved issues

Fix: CHECKBOX-1709

Documentation

N;/A

Tests

N/A

This is done because the value may be 0, which
is a valid value for it (delay == 0)
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (65da1f9) to head (778a7c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1658   +/-   ##
=======================================
  Coverage   48.99%   48.99%           
=======================================
  Files         372      372           
  Lines       40315    40319    +4     
  Branches     6810     6810           
=======================================
+ Hits        19751    19755    +4     
  Misses      19842    19842           
  Partials      722      722           
Flag Coverage Δ
checkbox-ng 69.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

I wish this _validate function was a little bit more flexible to handle this internally, but on the other hand I don't want to start overengineering things here...

@Hook25 Hook25 merged commit f6f1b9b into main Dec 17, 2024
48 checks passed
@Hook25 Hook25 deleted the hotfix_delay_nonfloat branch December 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants