Add the missing sort for lsusb in reboot_check_test.py and fix unused device comparison result (BugFix) #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
+ Coverage 48.00% 48.02% +0.02%
==========================================
Files 371 371
Lines 39833 39849 +16
Branches 6730 6732 +2
==========================================
+ Hits 19121 19138 +17
Misses 19994 19994
+ Partials 718 717 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tomli380576
changed the title
tomli380576
changed the title
eugene-yujinwu
pushed a commit
to eugene-yujinwu/checkbox
that referenced
this pull request
Dec 31, 2024
… device comparison result (BugFix) (canonical#1607) * fix: missing sort in reboot_check_test.py * fix: detailed diff * fix: device comp result never used * test: increase coverage * feat: use -q to suppress fwts progress messages * fix: restore stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
compare_device_listsResolved issues
checkbox-support-lsusb | sortstep that was missing in the python version. Adding this back to preserve the same behavior.Documentation
Tests
Unit tests
Sideloaded the fix on 202312-33267 and plugged in an USB stick during reboot to force a device difference. The fix correctly reports that the device config changed and failed the test case