Executing a first run without ignoring the output on disk tests (Bugfix) #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
=======================================
Coverage 48.03% 48.03%
=======================================
Files 371 371
Lines 39850 39850
Branches 6734 6734
=======================================
Hits 19140 19140
Misses 19993 19993
Partials 717 717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
approved these changes
Nov 11, 2024
eugene-yujinwu
pushed a commit
to eugene-yujinwu/checkbox
that referenced
this pull request
Dec 31, 2024
…ix) (canonical#1592) Executing a first run without ignoring the output on disk tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have created a quick fix to at show the whole output of hdparm the first run, because the test was always showing the
Device $disk is too small! Aborting test.message ifhdparmwas failing for any reason.Also making the test fail if no disk is selected as a parameter.
Resolved issues
N/A
Documentation
Tests
checkbox-cli run com.canonical.certification::disk-automated