Fixing index & type errors in prime_offload_tester.py (Bugfix) #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 371 371
Lines 39833 39837 +4
Branches 6730 6730
=======================================
+ Hits 19121 19125 +4
Misses 19994 19994
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tomli380576
changed the title
eugene-yujinwu
pushed a commit
to eugene-yujinwu/checkbox
that referenced
this pull request
Dec 31, 2024
…ical#1588) * fix: make annotations compatible with py 3.5 * fix: non-null assertions, comments * fix: root check * fix: only the letter 'g' was used in offloading to specific gpu test * style: less brackets * fix: update unit tests to reflect the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue in the Resolved Issues section and replaced some type annotations with ones supported in python 3.5
Resolved issues
If
prime_offload_tester.pywas run with arguments likepython3 prime_offload_tester.py -d i915 -p 0000:00:02.0and the command to check isglxgears, the test always passes because it was checking if"glxgears"[0]is one of the clients of this GPU. Since"glxgears"[0] == 'g', it always matches the g in "tgid" in/sys/kernel/debug/dri/<card_pci_id>/clients.Now it will check if the entire string "glxgears" appears in the file
Documentation
Tests
Unit tests
Ran the script on 202408-34290 with
-d i915 -p 0000:00:02.0(Intel + NVIDIA desktop, expected to fail) and it correctly reports that prime offload didn't work