Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed resizing method from NEAREST to AREA (BugFix) #1586

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

fernando79513
Copy link
Collaborator

@fernando79513 fernando79513 commented Nov 7, 2024

Description

The quality test was failing with an image with acceptable quality (see #1559). We have modified the interpolation algorithm so it does not accentuate the noise when downscaling the image, changing from NEAREST to AREA interpolation.

Resolved issues

#1559

Documentation

N/A

Tests

Tested with the failing image (see #1559)
Tested on the failing device. The score went from:
The BRISQUE score is too high: 72.13535618808396 > 60
to
BRISQUE score: 32.9690039977346

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.00%. Comparing base (7b5dd02) to head (cca31ca).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   48.00%   48.00%           
=======================================
  Files         371      371           
  Lines       39833    39833           
  Branches     6730     6730           
=======================================
  Hits        19121    19121           
  Misses      19994    19994           
  Partials      718      718           
Flag Coverage Δ
checkbox-support 60.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fernando79513 fernando79513 changed the title Changed resizing method from NEAREST to AREA Changed resizing method from NEAREST to AREA (BugFix) Nov 8, 2024
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the example pictures

@fernando79513 fernando79513 merged commit d856704 into main Nov 8, 2024
44 of 45 checks passed
@fernando79513 fernando79513 deleted the brisque-change-scaling-method branch November 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants