Add manifest gate for obex tests (bugfix) #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the test from the exclusion list this way once we have the hardware to do sru obex tests we just need to enable it via the manifest without changing the tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 371 371
Lines 39833 39833
Branches 6730 6730
=======================================
Hits 19121 19121
Misses 19994 19994
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pieqq
requested changes
Nov 7, 2024
pieqq
previously approved these changes
Nov 14, 2024
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
pieqq
approved these changes
Nov 14, 2024
pieqq
approved these changes
Nov 21, 2024
eugene-yujinwu
pushed a commit
to eugene-yujinwu/checkbox
that referenced
this pull request
Dec 31, 2024
* Add manifest gate for obex tests This also removes the test from the exclusion list this way once we have the hardware to do sru obex tests we just need to enable it via the manifest without changing the tests * Better description Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com> --------- Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The obex test was introduced with the only gate being the presence of the software to test it. This is problematic because the software will always be installed in the snap, but not all platforms support this extension. Additionally one needs the hardware to test this capability as well. For this reason we have decided to introduce a new manifest to gate the execution of this test because it is currently failing in sru (we had to manually exclude it) and in snap testing (where it is non-trivial to exclude).
This also removes the test from the exclusion list, this way once we have the hardware to do sru obex tests we just need to enable it via the manifest without changing the test plans
Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1646
Documentation
N/A
Tests
N/A
WARNING: This modifies com.canonical.certification::sru-server