Remove usb-c/hid job (New) #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This job was originally written when support for USB-C ports was introduced. However, it doesn't really make sense to have this, given that: - there is a `usb-c/c-to-a-adapter/hid` job - when a HID is used over USB-C, it uses the USB 2.0 bus used by USB-A HID
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 371 371
Lines 39833 39833
Branches 6730 6730
=======================================
Hits 19121 19121
Misses 19994 19994
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM~~ |
Hook25
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job was originally written when support for USB-C ports was introduced. However, it doesn't really make sense to have this, given that:
usb-c/c-to-a-adapter/hidjobThis job is a cert-blocker and impacts issuance of Certificate for some projects, but there is not much value in having it in the certification program.
Description
Resolved issues
Documentation
Tests