Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore common file extensions in ignored files warning (BugFix) #1583

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

pedro-avalos
Copy link
Collaborator

Description

  • Add an ignore list for common file extension types that shouldn't trigger a warning.

Resolved issues

Documentation

Tests

Tested locally.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.02%. Comparing base (9c994f1) to head (2d815a9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
+ Coverage   48.00%   48.02%   +0.02%     
==========================================
  Files         371      371              
  Lines       39833    39846      +13     
  Branches     6730     6731       +1     
==========================================
+ Hits        19121    19136      +15     
+ Misses      19994    19993       -1     
+ Partials      718      717       -1     
Flag Coverage Δ
checkbox-ng 68.64% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedro-avalos pedro-avalos marked this pull request as ready for review November 7, 2024 13:12
@pedro-avalos pedro-avalos requested review from pieqq and Hook25 November 7, 2024 13:12
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ty

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, forgot about the unit tests

Can you add a couple of unit tests (one per if branch?) ty

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@Hook25 Hook25 force-pushed the filter-ignored-files-warnings branch from 4946653 to 2d815a9 Compare November 8, 2024 14:12
@Hook25 Hook25 merged commit 498c548 into main Nov 8, 2024
49 checks passed
@Hook25 Hook25 deleted the filter-ignored-files-warnings branch November 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings when pycache files are found in a provider
2 participants