-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore common file extensions in ignored files warning (BugFix) #1583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
+ Coverage 48.00% 48.02% +0.02%
==========================================
Files 371 371
Lines 39833 39846 +13
Branches 6730 6731 +1
==========================================
+ Hits 19121 19136 +15
+ Misses 19994 19993 -1
+ Partials 718 717 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, forgot about the unit tests
Can you add a couple of unit tests (one per if branch?) ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty
4946653
to
2d815a9
Compare
Description
Resolved issues
Documentation
Tests
Tested locally.