Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GPGPU jobs by using siblings field (New) #1581

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

pedro-avalos
Copy link
Collaborator

Description

  • Simplifies and reduces the line length for the jobs defined in the GPGPU provider

Resolved issues

Documentation

Tests

@pedro-avalos pedro-avalos marked this pull request as ready for review November 6, 2024 19:47
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.00%. Comparing base (7b5dd02) to head (9f17243).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage   48.00%   48.00%           
=======================================
  Files         371      371           
  Lines       39833    39833           
  Branches     6730     6730           
=======================================
  Hits        19121    19121           
  Misses      19994    19994           
  Partials      718      718           
Flag Coverage Δ
provider-gpgpu 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1!
It looks cleaner now.

@fernando79513 fernando79513 merged commit 9c994f1 into main Nov 8, 2024
41 checks passed
@fernando79513 fernando79513 deleted the simplify-gpgpu-jobs branch November 8, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants