-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save submission url to file (bugfix) #1561
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
+ Coverage 47.88% 48.00% +0.12%
==========================================
Files 371 371
Lines 39820 39833 +13
Branches 6731 6730 -1
==========================================
+ Hits 19066 19121 +55
+ Misses 20042 19994 -48
- Partials 712 718 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge thanks for taking care of this. +1
Description
When submitting to C3, Checkbox receives a submission URL. This url is printed to the console. It is very hard and hackish to retreive this URL from the stdout of the process, therefore this adds a new rule to the exporter that also propagates this URL to a file on disk, printing the location like others do
Resolved issues
N/A
Documentation
N/A
Tests
This adds two new unit tests for the functionality + 1 for a small refactoring