Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save submission url to file (bugfix) #1561

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Oct 24, 2024

Description

When submitting to C3, Checkbox receives a submission URL. This url is printed to the console. It is very hard and hackish to retreive this URL from the stdout of the process, therefore this adds a new rule to the exporter that also propagates this URL to a file on disk, printing the location like others do

Resolved issues

N/A

Documentation

N/A

Tests

This adds two new unit tests for the functionality + 1 for a small refactoring

Minor: always return the same timestamp so that all artifacts have the same root
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.00%. Comparing base (fc12ed5) to head (3b916a0).
Report is 94 commits behind head on main.

Files with missing lines Patch % Lines
checkbox-ng/checkbox_ng/launcher/stages.py 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   47.88%   48.00%   +0.12%     
==========================================
  Files         371      371              
  Lines       39820    39833      +13     
  Branches     6731     6730       -1     
==========================================
+ Hits        19066    19121      +55     
+ Misses      20042    19994      -48     
- Partials      712      718       +6     
Flag Coverage Δ
checkbox-ng 68.60% <95.83%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@boukeas boukeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for taking care of this. +1

@Hook25 Hook25 merged commit 8f4bd2b into main Oct 25, 2024
50 checks passed
@Hook25 Hook25 deleted the save_submission_url_to_file branch October 25, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants