Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing subprocess.PIPE in reboot_check_test.py (Bugfix) #1546

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

tomli380576
Copy link
Contributor

@tomli380576 tomli380576 commented Oct 17, 2024

Description

The new reboot check test was missing stdout=subprocess.PIPE in calls to subprocess.run which was causing it to return None for <CompletedProcess>.stdout

Resolved issues

#1548

Documentation

Tests

  1. The original test cases pass
  2. Side loaded on 202406-34083 and full wb/cb tests can be run

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.76%. Comparing base (37dcd06) to head (54c855c).
Report is 90 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1546   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files         370      370           
  Lines       39750    39750           
  Branches     6720     6720           
=======================================
  Hits        18987    18987           
  Misses      20048    20048           
  Partials      715      715           
Flag Coverage Δ
provider-base 24.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomli380576 tomli380576 requested a review from Hook25 October 17, 2024 02:58
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, lgtm

@Hook25 Hook25 merged commit b6d5bfa into main Oct 17, 2024
47 checks passed
@Hook25 Hook25 deleted the reboot-check-test-fix branch October 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The return value for the subprocess run in reboot_check_test.py is always None
3 participants