-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amd gpgpu tests (New) #1531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
+ Coverage 47.72% 47.81% +0.09%
==========================================
Files 370 371 +1
Lines 39739 39808 +69
Branches 6719 6730 +11
==========================================
+ Hits 18965 19034 +69
Misses 20059 20059
Partials 715 715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This wrapper runs RVS with the pre-defined module configuration found in `data/rvs-*.conf`, and then validates that the module test was successsful.
Removed typing.override references.
This time for real?
db91479
to
8db3f2d
Compare
One design question I'd like some feedback on is how |
I think the configs are complex enough to be kept into separated config files. I would restrict the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes. You don't need to handle the return values if you are not going to use them. Consider just raising a SystemExit()
with the message you want to simplify the code.
- Use `SystemExit` instead of unused return values. - Don't use `re` where not needed - Use `_validate_output` instead of overriding `_run`.
- Added some fail descriptors - Remove unnecessary check in `parse_args` since I added the `choices` parameter
Since the script only runs one module at a time, it makes more sense to take the path to the config file directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1!
Description
Resolved issues
Addresses CHECKBOX-969 and CHECKBOX-1539.
Documentation
Coverage tests are included with this PR.
Tests
I tested this on my desktop, which has an AMD GPU (
AMD Radeon RX 6750 XT
). NOTE: For some AMD GPUs, you may need to change the environment variableHSA_OVERRIDE_GFX_VERSION
forrvs
to recognize that your GPU is compatible with some ROCm/HIP functions. For example, for my GPU, I had to edit the value to10.3.0
.