Fix touchscreen tests on ARM64 via remote (bugfix) #1528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the touchscreen tests via remote, the user is promted to rotate the rectangle on a window but the
user-interact-verify
job (silently) fails to start the window at all. When the stderr is un-silenced, the following error is printed in the console:Timer is a builtin type of QT and this happens for any other type (removing the timer just makes it fail on the next builtin type).
After much investigation, and thanks to the reported fact that the test starts fine if launched from the
checkbox.shell
or locally, I found that the problem is the missing envvar in this PR. This fixes the propagation of the envvar. I have whitelisted it instead of explicitly requiring it in the test because I believe that one doesn't have to understand exactly how QT works when writing a test, so they don't need to reason about which QT envvars are needed.Resolved issues
Fixes: CHECKBOX-1511
Fixes: #1371
Documentation
N/A
Tests
I have built and ran the test via remote with the following launcher. The window now shows up even via remote when before it did not.
To test it yourself use this checkbox24 snap, built from this branch (or build it yourself on arm64):