-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate checkbox-dss-validation to checkbox/contrib (New) #1524
Conversation
cecf1cc
to
a60eb52
Compare
The Workflow validation workflow is failing because the Created issue #1525 for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick glance at this, I noticed a few things that should be changed in the provider's manage.py file.
contrib/checkbox-dss-validation/checkbox-provider-dss/manage.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-dss-validation/checkbox-provider-dss/manage.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-dss-validation/checkbox-provider-dss/manage.py
Outdated
Show resolved
Hide resolved
New run in Testflinger after making requested changes: 4d890e0f-327c-4639-9aba-6334b413c777 |
* the original source repo was at commit bc07d01: <https://github.com/canonical/checkbox-dss-validation/tree/bc07d017e32706fd1578c0982c50d997ed8d47ac>. * the following directories or their contents were NOT copied - .github - checkbox-provider-dss/bin : because it had binary files, not used anywhere * no other modifications were made to the copied files
This reverts commit 0f42780. Updating the namespace starts to fail validation with errors like: error: units/jobs.pxu:4: job 'intel_gpu/host_gpu_avail', field 'requires', unit 'com.canonical.contrib::executable' is not available
f943f74
to
58860ba
Compare
As described in the readme, providers in the contrib area must have a namespace that includes the word contrib. Switching from `com.canonical.certification` to `com.canonical.contrib`. This means that jobs and test plans from the base providers need to be prefixed with the `com.canonical.certification` namespace.
Tests pass in Testflinger after changing namespace. |
Dismissing and approving as requested on MM
Description
Copied the most relevant files from the original repo at commit
bc07d01
and placed them in the newly created directory atcontrib/checkbox-dss-validation
. Solutions QA team has been added to.github/CODEOWNERS
for the relevant directories and GitHub workflows.Files under
checkbox-provider-dss/bin
in the original repo were not copied because it had a binary file, and none of the files were being used in the jobs anyway.The only relevant GitHub workflow for regression testing of DSS was also copied. The relevant workflow has to be run in Testflinger, and its definition has been added to
.github/workflows
, while the relevant Testflinger job's definition has been copied tocontrib/checkbox-dss-validation/testflinger/job-def.yaml
directory. These files have changes from the original so that they point to the relevant directory in this repository instead of the original one.Nevertheless, I have not made any changes to this repository's settings to enable running the workflow with Testflinger. I did not see the workflow being available to run in the GitHub Actions tab for this repo to check if the workflows will run or not.
Similarly, minimal updates (from the original) have been made to the README of the provider to now point to this repository instead of the original one in instructions.
An attempt was made to change the namespace of the provider from
com.canonical.certification
tocom.canonical.contrib
as suggested incontrib
's README, but this lead to errors during validation of the provider.Details of the validation errors on changing namespace to `contrib`
Resolved issues
Documentation
No updates to Checkbox documentation.
Tests
Testing was done using the following Testflinger job definition, with a successful run 7014854f-82c9-45cc-8374-b9c91f8f2046: