-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ce-oem]Revise optee test script and job (Bugfix) #1518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
=======================================
Coverage 47.72% 47.72%
=======================================
Files 370 370
Lines 39739 39739
Branches 6719 6719
=======================================
Hits 18965 18965
Misses 20059 20059
Partials 715 715 ☔ View full report in Codecov by Sentry. |
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/look_up_xtest.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/look_up_xtest.py
Outdated
Show resolved
Hide resolved
We can run the xtest from both gadget and other test apps
Co-authored-by: stanley31huang <stanley.huang@canonical.com>
3a92aa2
to
0be9f75
Compare
Handle no xtest installed Handle find different snap of xtest and tee
0be9f75
to
e69835e
Compare
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/look_up_xtest.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/xtest_install_ta.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/look_up_xtest.py
Outdated
Show resolved
Hide resolved
…test.py Co-authored-by: stanley31huang <stanley.huang@canonical.com>
@stanley31huang I've pushed the fix. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR let user to run the xtest from both gadget or other test apps.
And also fix the issue that
tee-supplicant
does not run before the test.Description
Resolved issues
Documentation
Tests
Sideload result without manifest on Baoshan. The xtest is from other test snap in this platform.
https://certification.canonical.com/hardware/202405-34026/submission/397773/
Sideload result without manifest on Shiner. The xtest is from gadget in this platform.
https://certification.canonical.com/hardware/202211-30806/submission/397790/