Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ce-oem]Revise optee test script and job (Bugfix) #1518

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Conversation

rickwu666666
Copy link
Contributor

This PR let user to run the xtest from both gadget or other test apps.
And also fix the issue that tee-supplicant does not run before the test.

Description

Resolved issues

Documentation

Tests

Sideload result without manifest on Baoshan. The xtest is from other test snap in this platform.
https://certification.canonical.com/hardware/202405-34026/submission/397773/

Sideload result without manifest on Shiner. The xtest is from gadget in this platform.
https://certification.canonical.com/hardware/202211-30806/submission/397790/

@fernando79513 fernando79513 added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.72%. Comparing base (cd772da) to head (b7f9219).
Report is 98 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   47.72%   47.72%           
=======================================
  Files         370      370           
  Lines       39739    39739           
  Branches     6719     6719           
=======================================
  Hits        18965    18965           
  Misses      20059    20059           
  Partials      715      715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickwu666666 rickwu666666 changed the title Revise optee test script and job (Bugfix) [ce-oem]Revise optee test script and job (Bugfix) Oct 1, 2024
rickwu666666 and others added 3 commits October 8, 2024 08:34
We can run the xtest from both gadget and other test apps
Co-authored-by: stanley31huang <stanley.huang@canonical.com>
Handle  no xtest installed

Handle find different snap of xtest and tee
rickwu666666 and others added 2 commits October 9, 2024 07:37
@rickwu666666
Copy link
Contributor Author

@stanley31huang I've pushed the fix. Thanks for the review.

Copy link
Collaborator

@stanley31huang stanley31huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickwu666666 rickwu666666 merged commit 2226b2c into main Oct 15, 2024
12 checks passed
@rickwu666666 rickwu666666 deleted the revise-xtest-test branch October 15, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ce-oem The PR only contains to the ce-oem provider under the contrib area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants