Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the camera job cmd with right camera tests (Bugfix) #1515

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

seankingyang
Copy link
Contributor

@seankingyang seankingyang commented Sep 30, 2024

Description

Correct job cmd the id: camera/display_{name} and id: camera/still_{name}.

I saw it updated in #1400 's commit, but missing after the PR merged.

Resolved issues

-----------[ Webcam still image capture test for Intel_MIPI_Camera ]------------
ID: com.canonical.certification::camera/still_video0
Category: com.canonical.plainbox::camera
Purpose:

This test will check that the Intel_MIPI_Camera works

Steps:

1. Click on Test to display a still image from the camera for ten seconds.

Pick an action
    => press ENTER to continue
  c => add a comment
  s => skip this job
  q => save the session and quit
[csq]: 
... 8< -------------------------------------------------------------------------
usage: camera_test.py [-h] [--debug] {detect,led,video,image,resolutions} ...
camera_test.py: error: argument test: invalid choice: 'still' (choose from 'detect', 'led', 'video', 'image', 'resolutions')
------------------------------------------------------------------------- >8 ---


--------------[ Webcam video display test for Intel_MIPI_Camera ]---------------
ID: com.canonical.certification::camera/display_video0
Category: com.canonical.plainbox::camera
Purpose:

This test will check that the Intel_MIPI_Camera camera works

Steps:

1. Click on Test to display a video capture from the camera for ten seconds.

Pick an action
    => press ENTER to continue
  c => add a comment
  s => skip this job
  q => save the session and quit
[csq]: 
... 8< -------------------------------------------------------------------------
usage: camera_test.py [-h] [--debug] {detect,led,video,image,resolutions} ...
camera_test.py: error: argument test: invalid choice: 'display' (choose from 'detect', 'led', 'video', 'image', 'resolutions')

Documentation

Tests

@seankingyang seankingyang added bug Something isn't working Importance: Critical labels Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (0463efb) to head (2b08908).
Report is 106 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1515   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files         369      369           
  Lines       39596    39596           
  Branches     6691     6691           
=======================================
  Hits        18833    18833           
  Misses      20051    20051           
  Partials      712      712           
Flag Coverage Δ
provider-base 24.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks

@Hook25 Hook25 merged commit 2605982 into main Sep 30, 2024
42 checks passed
@Hook25 Hook25 deleted the Correct_Camera_JOB_CMD branch September 30, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Importance: Critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants