Fix the combination of backup_loc path (Bugfix) #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankingyang
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
Coverage 47.48% 47.48%
=======================================
Files 369 369
Lines 39586 39586
Branches 6685 6685
=======================================
Hits 18798 18798
Misses 20077 20077
Partials 711 711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seankingyang
changed the title
seankingyang
changed the title
|
This PR fix the bug https://bugs.launchpad.net/sutton/+bug/2081247. The test result after apply the fix: https://certification.canonical.com/hardware/202409-35352/submission/396157/test-results/ |
|
LGTM |
fernando79513
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the path combination fo
backup_loc.The reason is
Pathcan't combine the path start with "/", so need to make thebasediris the relative path with "/".Resolved issues
It will break the script if the machine connect with the wifi AP before test when it save the connection's configuration.
This will be 100% fail when the above situation.
Documentation
Tests
https://certification.canonical.com/hardware/202409-35379/submission/396113/test-results/pass/