Fix envvars + propagation in lab pipeline (infra) #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor: group steps together in the GH output
boukeas
reviewed
Sep 23, 2024
boukeas
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lab pipeline was failing on 24.04 because one of the packages was using the interactive frontend to fetch some value from the user. This was because the
aptcommand was launched without the-Eflag, therefore the environment was not inherited from the parent shell, clearing the cusom environment. Additionally, theDEBIAN_FRONTENDenvvar was unset, leaving to the specific workflow the chore to set it. This fixes both of these issues.Minor: this also adds grouping to the installer output, making it easier to read
Minor: this also enables exit on error, as this makes the output easier to read on failure
Resolved issues
Fixes: pipeline currently not working on noble (not working if any dependency asks for manual interaction)
Fixes: CHECKBOX-1579
Documentation
N/A
Tests
Failing run: https://github.com/canonical/checkbox/actions/runs/10958861773/job/30429994853
Passing run post patch: https://github.com/canonical/checkbox/actions/runs/10989122085/job/30506715951
After edit inline DEBIAN_FRONTED