-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifest units to expand output (New) #1489
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 45.87% 45.88% +0.01%
==========================================
Files 367 367
Lines 39156 39167 +11
Branches 6622 6628 +6
==========================================
+ Hits 17961 17970 +9
- Misses 20504 20505 +1
- Partials 691 692 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments in _get_relevant_manifest_units
, otherwise that would be pretty complicated to parse!
I've played with it a little bit and it seems to do what it's advertised for.
I only have one inline comment about the fact that now every job has a template_id
attribute, even if it's null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
We need a way to programmatically fetch the list of manifest entries needed to run a test plan. This makes it easier to automatically verify manifests in CI, track changes to testplans manifest entries and more. This adds manifest units to the
expand
command filtering out those that aren't used in the testplan.Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1555
Documentation
This adds plenty comments to the expander.
Tests
WIP