Sd card not tested (BugFix) #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
+ Coverage 47.44% 47.48% +0.03%
==========================================
Files 368 368
Lines 39549 39579 +30
Branches 6678 6684 +6
==========================================
+ Hits 18764 18794 +30
Misses 20075 20075
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SD card reader in some PC platforms is a combo card reader combines USB & SDHC. This PR brings back the old behavior of the mediacard tests in which we were checking for both a mediacard and a USB insertion:
checkbox-support-run_watcher storage mediacard_comboAll of the mediacard tests have been modified to use this behavior.
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1551
#1456
Documentation
Tests
Tested with a USB-C to SD adapter in a Laptop with 22.04
Tested on the device that was experiencing the issue: CID: 202408-34238 SEN16MLK-DVT1-C1M