Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add depends for suspend/{index}_suspend_after_switch_to_card_{product_slug}_auto (BugFix) #1484

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

hanhsuan
Copy link
Contributor

Description

The suspend/{index}_suspend_after_switch_to_card_{product_slug}_auto was no depends graphics/{index}_auto_switch_card_{product_slug} and make it runs unexpectedly.
Therefore, add depends to suspend/{index}_suspend_after_switch_to_card_{product_slug}_auto to avoid this.

Resolved issues

#1446

Documentation

Tests

submission

…_slug}_auto

to avoid running this test unexpectedly
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.42%. Comparing base (3ba7e2c) to head (cead45b).
Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   47.10%   47.42%   +0.32%     
==========================================
  Files         368      368              
  Lines       39435    39541     +106     
  Branches     6667     6677      +10     
==========================================
+ Hits        18574    18753     +179     
+ Misses      20156    20076      -80     
- Partials      705      712       +7     
Flag Coverage Δ
provider-base 24.02% <ø> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need it to run only when auto_switch_card passes? If so, this is correct, please remove after, as to not duplicate the constraint (depends implies after)

providers/base/units/suspend/suspend-graphics.pxu Outdated Show resolved Hide resolved
@hanhsuan hanhsuan requested a review from Hook25 September 19, 2024 00:01
@Hook25 Hook25 merged commit ea6f0a8 into main Sep 19, 2024
43 checks passed
@Hook25 Hook25 deleted the add_depends_to_suspend_after_switch_to_card branch September 19, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants