-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordering of storage tests (BugFix) #1454
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 47.10% 47.11% +0.01%
==========================================
Files 368 368
Lines 39435 39443 +8
Branches 6667 6668 +1
==========================================
+ Hits 18574 18585 +11
+ Misses 20156 20155 -1
+ Partials 705 703 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdfe449
to
c777941
Compare
c777941
to
617432a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice, better descriptions, better structure, less jobs, less sibilings, usage of the after-suspend flag, solves the issue... Well done! +1
Verify Pass on Boashan G1200 snap info
Submission: https://certification.canonical.com/hardware/202307-31864/submission/398134/test-results/?term=zapper-usb |
WARNING: This modifies com.canonical.certification::sru-server
Description
As commented in #910, if the USB manual tests fail, when user reruns the failed jobs, the execution order will lose the original sequence.
This PR aims to solve this issue by merging the 3 storage tests insertion/storage/removal into one unique test that performs the three actions.
Here you can find the conversation in Mattermost
Resolved issues
#91
https://warthogs.atlassian.net/browse/CHECKBOX-1497
Documentation
N/A
Tests
Storage tests (22.04 laptop)
submission_2024-09-16T10.44.35.228920.zip
Zapper USB tests
submission_2024-09-16T11.58.24.029262.zip