Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of storage tests (BugFix) #1454

Merged
merged 18 commits into from
Sep 18, 2024
Merged

Ordering of storage tests (BugFix) #1454

merged 18 commits into from
Sep 18, 2024

Conversation

fernando79513
Copy link
Collaborator

@fernando79513 fernando79513 commented Sep 4, 2024

WARNING: This modifies com.canonical.certification::sru-server

Description

As commented in #910, if the USB manual tests fail, when user reruns the failed jobs, the execution order will lose the original sequence.

This PR aims to solve this issue by merging the 3 storage tests insertion/storage/removal into one unique test that performs the three actions.

Here you can find the conversation in Mattermost

Resolved issues

#91
https://warthogs.atlassian.net/browse/CHECKBOX-1497

Documentation

N/A

Tests

Storage tests (22.04 laptop)
submission_2024-09-16T10.44.35.228920.zip
Zapper USB tests
submission_2024-09-16T11.58.24.029262.zip

@fernando79513 fernando79513 marked this pull request as draft September 4, 2024 17:23
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.11%. Comparing base (3ba7e2c) to head (550039b).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   47.10%   47.11%   +0.01%     
==========================================
  Files         368      368              
  Lines       39435    39443       +8     
  Branches     6667     6668       +1     
==========================================
+ Hits        18574    18585      +11     
+ Misses      20156    20155       -1     
+ Partials      705      703       -2     
Flag Coverage Δ
checkbox-support 60.49% <100.00%> (+0.11%) ⬆️
provider-base 23.04% <ø> (ø)
provider-certification-client 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fernando79513 fernando79513 force-pushed the ordering-of-storage-tests branch from bdfe449 to c777941 Compare September 4, 2024 17:36
@fernando79513 fernando79513 force-pushed the ordering-of-storage-tests branch from c777941 to 617432a Compare September 4, 2024 17:37
@fernando79513 fernando79513 marked this pull request as ready for review September 16, 2024 12:29
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, better descriptions, better structure, less jobs, less sibilings, usage of the after-suspend flag, solves the issue... Well done! +1

@Hook25 Hook25 merged commit 17e69f2 into main Sep 18, 2024
49 checks passed
@Hook25 Hook25 deleted the ordering-of-storage-tests branch September 18, 2024 14:38
@baconYao
Copy link
Contributor

baconYao commented Oct 4, 2024

Verify Pass on Boashan G1200

snap info

checkbox22                 4.2.0-dev103      1207   latest/edge      ce-certification-qa  -

Submission: https://certification.canonical.com/hardware/202307-31864/submission/398134/test-results/?term=zapper-usb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants