-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sd card not tested (BugFix) #1451
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
+ Coverage 45.72% 45.75% +0.02%
==========================================
Files 367 367
Lines 39134 39163 +29
Branches 6618 6625 +7
==========================================
+ Hits 17895 17918 +23
- Misses 20565 20569 +4
- Partials 674 676 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9b2d3dd
to
f4b0fa5
Compare
6d57d6f
to
9fd975d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want to use that feature, but we do have it
WARNING: This modifies com.canonical.certification::sru-server
Description
This ticket introduces some changes to the disk tests.
The first of them is to include SD cards into the "DISK" category so we can run disk performance tests in devices that have root mounted on an SD card. This behavior was purposely ignored before.
But we have decided to include also SD cards into the "DISK" category so the disk tests are run also in these devices
We should keep in mind that these tests, particularly the storage test, put stress on the SD cards, which could potentially reduce their lifespan.
The second one is to ignore some disks for certain types of tests:
mtdblock
disks are ignored for storage tests.We discussed moving the disk-detecting logic to a separate resource instead of using "udevadm.py", but I think we can do that in a follow-up ticket.
Resolved issues
#1272
https://warthogs.atlassian.net/browse/CHECKBOX-1458
Documentation
N/A
Tests
The tests have been run in a laptop and in a Xilinx device with the root mounted in the SD card: