Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unicodedecode exception for reading fwts session log (BugFix) #1448

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

KaiChuan-Hsieh
Copy link
Contributor

Description

Try to capture the unicodedecode exception but not making the script crashed

Resolved issues

Fixes: SOMERVILLE-807

Tests

The test was performed by running the script to parse the problem session log, the script can handle the problem session log without crashing.

@KaiChuan-Hsieh KaiChuan-Hsieh changed the title BugFix: Fixed unicodedecode exception for readling fwts session log Fixed unicodedecode exception for readling fwts session log (BugFix) Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.77%. Comparing base (b92edc5) to head (0dcfce8).
Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
...kbox-support/checkbox_support/scripts/fwts_test.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   45.72%   45.77%   +0.04%     
==========================================
  Files         367      367              
  Lines       39134    39163      +29     
  Branches     6618     6622       +4     
==========================================
+ Hits        17894    17926      +32     
+ Misses      20565    20562       -3     
  Partials      675      675              
Flag Coverage Δ
checkbox-support 59.98% <85.71%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaiChuan-Hsieh KaiChuan-Hsieh changed the title Fixed unicodedecode exception for readling fwts session log (BugFix) Fixed unicodedecode exception for reading fwts session log (BugFix) Sep 3, 2024
@KaiChuan-Hsieh KaiChuan-Hsieh self-assigned this Sep 3, 2024
@KaiChuan-Hsieh
Copy link
Contributor Author

@pieqq

Hello,

Could you help to review the MP? thanks.

@KaiChuan-Hsieh KaiChuan-Hsieh force-pushed the fix-SOMERVILLE-807 branch 5 times, most recently from 7f2e503 to 0e9d4ad Compare September 11, 2024 06:54
FIXES: SOMERVILLE-807
@Hook25 Hook25 merged commit aa2fc97 into main Sep 11, 2024
40 of 41 checks passed
@Hook25 Hook25 deleted the fix-SOMERVILLE-807 branch September 11, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants