Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox-ce-oem] Fix all checks in ceoem (Bugfix) #1445

Merged
merged 7 commits into from
Sep 4, 2024
Merged

[checkbox-ce-oem] Fix all checks in ceoem (Bugfix) #1445

merged 7 commits into from
Sep 4, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Sep 2, 2024

Description

Fix the name length

Resolved issues

N/A

Documentation

N/A

Tests

N/A

fix the shell check issue
@LiaoU3 LiaoU3 changed the title [checkbox-ce-oem] Reduce length of the testplan name (Bugfix) [checkbox-ce-oem] Fix all checks in ceoem (Bugfix) Sep 3, 2024
@baconYao baconYao added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Sep 3, 2024
@baconYao baconYao requested a review from a team September 3, 2024 07:08
LiaoU3 and others added 3 commits September 3, 2024 16:35
fix the required parameter not available in Python 3.5
fix fstring error in Python 3.5
@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Sep 3, 2024

Thank you for your contribution! @stanley31huang

Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiaoU3 LiaoU3 merged commit 924882a into main Sep 4, 2024
10 checks passed
@LiaoU3 LiaoU3 deleted the fix_ceoem branch September 4, 2024 01:29
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.72%. Comparing base (b92edc5) to head (f82f070).
Report is 120 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1445   +/-   ##
=======================================
  Coverage   45.72%   45.72%           
=======================================
  Files         367      367           
  Lines       39134    39134           
  Branches     6618     6618           
=======================================
  Hits        17894    17894           
  Misses      20565    20565           
  Partials      675      675           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ce-oem The PR only contains to the ce-oem provider under the contrib area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants