Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audio playback/capture manifest definitions (bugfix) #1430

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pieqq
Copy link
Collaborator

@pieqq pieqq commented Aug 21, 2024

Description

Make it clearer what has_audio_playback and has_audio_capture stand for.

These two manifest entries have been there for a long time, but it was never clear what they meant exactly. This led to issues such as the recent #1329. By having a more clear definition, testers know whether or not they should set these manifest entries or not.

image

Resolved issues

Fix #1329

Documentation

Tests

Make it clearer what `has_audio_playback` and `has_audio_capture` stand
for.

Fix #1329
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.25%. Comparing base (b672f33) to head (a576aca).
Report is 115 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   45.25%   45.25%           
=======================================
  Files         367      367           
  Lines       39131    39131           
  Branches     6617     6617           
=======================================
  Hits        17707    17707           
  Misses      20751    20751           
  Partials      673      673           
Flag Coverage Δ
provider-base 18.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pieqq pieqq changed the title Update audio playback/capture manifest definitions Update audio playback/capture manifest definitions (bugfix) Aug 22, 2024
@pieqq pieqq merged commit 64b7afd into main Aug 22, 2024
43 of 45 checks passed
@pieqq pieqq deleted the update-audio-manifest branch August 22, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The audio/detect_sinks based on incorrect manifest entry
2 participants