Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpgpu setup script (BugFix) #1416

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Fix gpgpu setup script (BugFix) #1416

merged 2 commits into from
Aug 12, 2024

Conversation

pedro-avalos
Copy link
Collaborator

Description

The gpu-setup script did not set up the repository correctly, and it needed the apt repos to be refreshed.

Additionally, the data directories for the cuda-samples tests were not being created.

Resolved issues

n/a

Documentation

n/a

Tests

Running the providers/gpgpu/tools/gpu-setup script.

@pedro-avalos pedro-avalos requested a review from Hook25 August 12, 2024 16:07
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@pedro-avalos pedro-avalos marked this pull request as ready for review August 12, 2024 16:09
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.18%. Comparing base (ce1e91a) to head (2461dbf).
Report is 115 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         366      366           
  Lines       39107    39107           
  Branches     6612     6612           
=======================================
  Hits        17670    17670           
  Misses      20764    20764           
  Partials      673      673           
Flag Coverage Δ
provider-gpgpu 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedro-avalos pedro-avalos merged commit ff9f6b6 into main Aug 12, 2024
41 checks passed
@pedro-avalos pedro-avalos deleted the fix-gpgpu-tests-setup branch August 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants