-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage tests for stress_ng_test (New) #1412
Conversation
This required changing the parameter for `swap_space_ok` from the arguments namespace to just the swap size.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
+ Coverage 45.18% 45.67% +0.49%
==========================================
Files 366 367 +1
Lines 39107 39118 +11
Branches 6612 6613 +1
==========================================
+ Hits 17670 17867 +197
+ Misses 20764 20577 -187
- Partials 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions here and there, I'm not sure why but a couple of tests are failing for me locally. Also, please mock range, it is very taxing to run it (and this is ran all the times)
Remove leading `stress_ng_test` where not needed
Moved `os.geteuid` and `shutil.which` mocks to class level.
Description
This adds coverage unit tests for
providers/base/bin/stress_ng_test.py
. Some minor edits tostress_ng_test.py
were required.Resolved issues
n/a
Documentation
n/a
Tests
This has been tested using
python -m coverage run manage.py test -u
.