Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply the testing command and replace 'and' with '&&' for suspend_advanced_auto (Bugfix) #1406

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Aug 9, 2024

Description

  1. Simplify testing command
  2. Replace 'and' with the correct '&&'

Resolved issues

N/A

Documentation

N/A

Tests

https://certification.canonical.com/hardware/202406-34151/submission/386039/

@LiaoU3 LiaoU3 changed the title Simply the testing command and replan 'and' with '&&' for suspend_advanced_auto(Bugfix) Simply the testing command and replan 'and' with '&&' for suspend_advanced_auto (Bugfix) Aug 9, 2024
@LiaoU3 LiaoU3 changed the title Simply the testing command and replan 'and' with '&&' for suspend_advanced_auto (Bugfix) Simply the testing command and replace 'and' with '&&' for suspend_advanced_auto (Bugfix) Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.18%. Comparing base (1b9cc05) to head (cb5acbc).
Report is 111 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1406   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         366      366           
  Lines       39103    39103           
  Branches     6610     6610           
=======================================
  Hits        17670    17670           
  Misses      20760    20760           
  Partials      673      673           
Flag Coverage Δ
provider-base 18.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Aug 9, 2024

BTW, I am also surprised that no one bump into this problem in the past 3 months.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ty

@Hook25 Hook25 merged commit a6e44d4 into main Aug 9, 2024
44 of 45 checks passed
@Hook25 Hook25 deleted the suspend branch August 9, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants