Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip EDID test if there's no desktop session running (BugFix) #1404

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

p-gentili
Copy link
Collaborator

@p-gentili p-gentili commented Aug 8, 2024

Description

The Zapper EDID job is only checking resources on the Zapper side, not on the DUT. This means the testcase runs on server images as well, failing.

This PR propose a new resource job, desktop_session, which is used by the EDID job to make sure it runs only on desktop.

WARNING: This modifies com.canonical.certification::sru

Resolved issues

N/A

Documentation

N/A

Tests

Current host is not supported.

Side-loading the provider:

-----------------------------[ Running job 4 / 5 ]------------------------------
------[ Check whether a desktop session is available and of which type. ]-------
ID: com.canonical.certification::desktop_session
Category: Informational tests
--------------------------------------------------------------------------------
desktop_session: False
session_type: None
--------------------------------------------------------------------------------
Outcome: job passed
-----------------------------[ Running job 5 / 5 ]------------------------------
---[ Check if the system automatically changes the resolution based on EDID ]---
ID: com.canonical.certification::monitor/zapper-edid
Category: Monitor tests
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Outcome: job cannot be started

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.19%. Comparing base (fd17448) to head (f4c9725).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/desktop_session.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1404   +/-   ##
=======================================
  Coverage   45.18%   45.19%           
=======================================
  Files         366      367    +1     
  Lines       39102    39118   +16     
  Branches     6609     6612    +3     
=======================================
+ Hits        17669    17680   +11     
- Misses      20760    20764    +4     
- Partials      673      674    +1     
Flag Coverage Δ
provider-base 18.71% <91.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@Hook25 Hook25 merged commit 4123afe into main Aug 13, 2024
41 checks passed
@Hook25 Hook25 deleted the desktop-session-resource branch August 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants