-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDID test fails at maximum resolution (BugFix) #1393
Conversation
It's common to have a mismatch between the available modes at EDID level and what the device actually supports. This commit selects the maximum allowed resolution and returns the applied configuration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
+ Coverage 45.12% 45.18% +0.05%
==========================================
Files 366 366
Lines 39058 39102 +44
Branches 6607 6609 +2
==========================================
+ Hits 17626 17669 +43
- Misses 20758 20760 +2
+ Partials 674 673 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if you like the change proposed below but it makes sense
Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
d067982
to
8c08ee4
Compare
Description
Another PR dedicated to the EDID job. It turns out that the new implementation (#1286) shed some light on the other related problem, where older machines could read the maximum allowed resolution.
In case where the HW doesn't support an available mode from the monitor EDID, no preferred mode is available (which makes sense). This PR takes care of such scenario, attempting to configure the monitor with the maximum available resolution.
Resolved issues
Resolves ZAP-678
Documentation
N/A
Tests
Tested on some machines.
Previous behaviour:
Running from source: