Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all possible builds to self hosted (infra) #1379

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Move all possible builds to self hosted (infra) #1379

merged 4 commits into from
Jul 30, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jul 30, 2024

Description

Currently, the core20 builds are broken due to snapcraft8 not supporting core20 remote builds anymore. Additionally, many of the things we build via remote build could actually be partially built via self hosted runners.
This PR does the following:

  • Move core18 frontend uc+classic and runtime to self hosted for arm64 and amd64
  • Move core20 armhf builds back to the old workflow
  • Minor: replace exclude with include (as it is more readable and correct)
  • Minor: explicitly expand the SNAPCRAFT_BUILDER_ID variable as the action doesn't seem to expand envvars anymore

Note: this doesn't move any core16 build to the self-hosted as the new version of the snapcore action doesn't seem to support it, see: https://github.com/canonical/checkbox/actions/runs/10143907516/job/28046289302

Resolved issues

Resolves: https://warthogs.atlassian.net/browse/CER-2693

Documentation

Inclusions documented in the comment above

Tests

Full run (without submit) here: https://github.com/canonical/checkbox/actions/runs/10160203825/job/28097642975

Note: remote builds for 22 and 24 fixed in 3aac73e
Note: duplicated builds of frontend amd64 18/20 fixed in 767777e

Hook25 added 4 commits July 30, 2024 15:19
Build snap but no upload for now

Fix SNAPCRAFT_BUILDER_ID and 16 type inclusion

Move back to the old workflow armhf remote builds

Wrong syntax snap daily
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for working on this!

@Hook25 Hook25 merged commit 27f8dab into main Jul 30, 2024
7 checks passed
@Hook25 Hook25 deleted the sc8_exp branch July 30, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants