-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "Initial Stress Tests" category to distinguish tests that are prepared for stress tests (BugFix) #1368
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
=======================================
Coverage 45.12% 45.12%
=======================================
Files 366 366
Lines 39058 39058
Branches 6607 6607
=======================================
Hits 17626 17626
Misses 20758 20758
Partials 674 674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compares to adding an additional category, I'd rather suggest to clean up / remove the duplicated ones and use com.canonical.plainbox::stress
for all the stress tests
28acd5e
to
903c3f7
Compare
@zongminl There are 2 test cases belong to catagory stress-tests: reboot-run-generator and init-boot-loop-data, and I just move them to com.canonical.plainbox::stress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay no more duplicate categories :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove the unused
com.canonical.certification::stress-tests
category entirely - There are still a few jobs using
com.canonical.certification::stress-tests
category, please also make the change for them
903c3f7
to
c336387
Compare
@zongminl Per your comments, the stress-tests category was removed, and two tests mentioned was change to category com.canonical.plainbox::stress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Fix: Two almost identical 'Stress Tests' lead to some confusion #1319
Add a new category named "Initial Stress Tests" to used for some initial tests of stress tests, such as init-boot-loop-data which used to create a baseline for other tests.
Description
Resolved issues
Two almost identical 'Stress Tests' lead to some confusion #1319
Documentation
Tests