-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both networkd and NetworkManger in netplan (New) #1301
Support both networkd and NetworkManger in netplan (New) #1301
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 45.72% 46.30% +0.58%
==========================================
Files 367 367
Lines 39134 39224 +90
Branches 6618 6636 +18
==========================================
+ Hits 17894 18164 +270
+ Misses 20565 20374 -191
- Partials 675 686 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5933112
to
14accb6
Compare
14accb6
to
ac16772
Compare
* Port bugfix from #1301 * Update tests
ac16772
to
6b39662
Compare
Rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job here! A bunch of minor comments and suggestions but nothing big.
I think at least one of the tests is wrong (test_main_success
). Please check that the test is testing the expected behavior.
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
23f6967
to
ff34f12
Compare
@fernando79513 please review these changes~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1!
Description
Netplan serves as a network configuration abstraction renderer and was officially released in the 24.04 LTS version.
Netplan functions as a configuration tool for back-end daemons managing network interfaces, such as NetworkManager or systemd-networkd.
In essence, Netplan acts as a configuration tool for back-end daemons managing network interfaces, independent of specific technologies.
In this PR, modify the
wifi_client_test_netplan.py
script to make it support both networkd and NetworkManger.generate_test_config
to create the configuration with the specified renderer.wait_for_routable
to support both networkd and NetworkManager._get_nmcli_state
to retrieve the connection state for NetworkManager.check_routable_state
to determine the appropriate_get_{nmcli | networkctl}_state
based on the renderer parameter.perform_ping_test
to accommodate both networkd and NetworkManager. (Obtain the Gateway method)get_gateway
, which will select the appropriate_get_{networkctl | nmcli}_gateway
based on the renderer parameter._get_networkctl_gateway
extracted from the func: perform_ping_test to support this functionality._get_nmcli_gateway
to obtain the gateway IP address from NetworkManager.print_journal_entries
to cater to both network and NetworkManager scenarios.According to the above issue, it need to add the following action:
Resolved issues
#1303 (Netplan missing the key-management: psk when wpa/wpa2)
Documentation
Tests
Run cmd on systemd-networkd machine 202405-34023
Run checkbox wireless test category on machine 202405-34023