feat: add *-secret-key-id charm configuration for flask, django, golang and fastapi framework charms #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
force-pushed
the
secret-key-id
branch
from
29fd92c to
e213c18
Compare
weiiwang01
changed the title
lengau
approved these changes
Feb 11, 2025
charmcraft/extensions/app.py
Outdated
| "description": "This configuration is similar to `flask-secret-key`, but instead accepts a Juju user secret ID. " | ||
| 'The secret should contain a single key, "value", which maps to the actual Flask secret key. ' | ||
| "To create the secret, run the following command: `juju add-secret my-flask-secret-key value=<secret-string> && juju grant-secret my-flask-secret-key flask-k8s`, " | ||
| "and use the outputted secret ID to configure this option.", |
There was a problem hiding this comment.
Suggested change
| "and use the outputted secret ID to configure this option.", | |
| "and use the output secret ID to configure this option.", |
There was a problem hiding this comment.
Thanks! Fixed the grammar issue and squashed the commits.
weiiwang01
force-pushed
the
secret-key-id
branch
from
e213c18 to
a7df6d9
Compare
…ng and fastapi framework charms
weiiwang01
force-pushed
the
secret-key-id
branch
from
a7df6d9 to
4994290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new
*-secret-key-idcharm configurations to Flask, Django, Golang, and FastAPI framework charms.The
*-secret-key-idconfiguration serves a similar purpose as the old*-secret-keyconfiguration but instead accepts Juju secrets, providing a more secure way to pass sensitive information like secret keys.This change is backward-compatible with deployments on Juju 3, as the old configuration still exists but takes lower precedence. However, it might not be compatible with Juju 2, as Juju 2 does not support Juju secrets.