Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix poetry-with description #2053

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

carlcsaposs-canonical
Copy link
Contributor

--with is required for optional and non-optional dependencies

see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299

corresponding PR in canonical/craft-parts#946

Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a non-blocking suggestion.

docs/howto/charm-to-poetry.rst Outdated Show resolved Hide resolved
--with is required for optional and non-optional dependencies

see python-poetry/poetry-plugin-export#212 and python-poetry/poetry-plugin-export#299

corresponding PR in canonical/craft-parts#946
@sergiusens sergiusens changed the title docs: Fix poetry-with description docs: fix poetry-with description Dec 19, 2024
@lengau lengau added this pull request to the merge queue Dec 19, 2024
Merged via the queue into canonical:main with commit 455880a Dec 19, 2024
28 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the poetry-docs branch December 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants