style(type): make pyright stricter #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/stricter-pyright
branch
from
3f64582 to
d1e604b
Compare
lengau
force-pushed
the
work/stricter-pyright
branch
from
0095972 to
d1e604b
Compare
tigarmo
approved these changes
Dec 18, 2024
| @@ -70,13 +70,13 @@ def run(self, parsed_args: argparse.Namespace) -> int: | |||
| return self._run_formatted(parsed_args.filepath, ignore=ignore) | |||
| return self._run_streaming(parsed_args.filepath, ignore=ignore) | |||
|
|
|||
| def _run_formatted(self, filepath: pathlib.Path, *, ignore=Container[str]) -> int: | |||
| def _run_formatted(self, filepath: pathlib.Path, *, ignore: Container[str]) -> int: | |||
mr-cal
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps two pyright warnings to errors and fixes those errors