Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload all images (not just current arch) with skopeo #2037

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Dec 12, 2024

Fixes #2020

CRAFT-3804

@lengau
Copy link
Collaborator Author

lengau commented Dec 12, 2024

@carlcsaposs-canonical - if I'm very lucky, this might be all we need for #2020. I don't have a good way to test it right now, so if you have time I'd appreciate you installing Charmcraft from the build artefact and trying it.

If it doesn't work, can we meet some time tomorrow or Monday to help me get the infrastructure I need to properly replicate this?

@carlcsaposs-canonical
Copy link
Contributor

Charmcraft from the build artefact and trying it

uploaded a multi-arch oci and it worked!

@lengau lengau force-pushed the work/2020/CRAFT-3804 branch from c4d3b86 to 4c0fd89 Compare December 16, 2024 15:38
@lengau lengau requested review from bepri and mr-cal December 16, 2024 17:12
@lengau lengau force-pushed the work/2020/CRAFT-3804 branch from 4c0fd89 to c3f6154 Compare December 16, 2024 17:12
@lengau lengau marked this pull request as ready for review December 16, 2024 17:12
Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet, nice work

@lengau lengau merged commit e84fd12 into main Dec 17, 2024
25 of 26 checks passed
@lengau lengau deleted the work/2020/CRAFT-3804 branch December 17, 2024 15:23
lengau added a commit to tmihoc/charmcraft that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy charm using multi-arch OCI uploaded with charmcraft 3
4 participants